Closed agarwal-navin closed 1 month ago
Metric Name | Baseline Size | Compare Size | Size Diff |
---|---|---|---|
aqueduct.js | 457.6 KB | 457.63 KB | ⯅ +35 Bytes |
azureClient.js | 555.31 KB | 555.35 KB | ⯅ +49 Bytes |
connectionState.js | 680 Bytes | 680 Bytes | ■ No change |
containerRuntime.js | 258.68 KB | 258.7 KB | ⯅ +14 Bytes |
fluidFramework.js | 391.58 KB | 391.59 KB | ⯅ +14 Bytes |
loader.js | 134.02 KB | 134.03 KB | ⯅ +14 Bytes |
map.js | 42.17 KB | 42.18 KB | ⯅ +7 Bytes |
matrix.js | 145.68 KB | 145.69 KB | ⯅ +7 Bytes |
odspClient.js | 523.45 KB | 523.5 KB | ⯅ +49 Bytes |
odspDriver.js | 97.55 KB | 97.57 KB | ⯅ +21 Bytes |
odspPrefetchSnapshot.js | 42.61 KB | 42.62 KB | ⯅ +14 Bytes |
sharedString.js | 162.69 KB | 162.7 KB | ⯅ +7 Bytes |
sharedTree.js | 382.09 KB | 382.1 KB | ⯅ +7 Bytes |
Total Size | 3.27 MB | 3.27 MB | ⯅ +245 Bytes |
Baseline commit: 3f00c6dbecaa614bae059dabd09f8e197b14dfdf
Generated by :no_entry_sign: dangerJS against 9f46ec7bcba366c8cf0bdf9d18fb3129a70320ec
Bug and root-cause
A GC test that validates deleted stats is flaky. The test uses sweep timeout of 200 ms. It does the following in sequence:
If 200 ms have passed before step 3 is run, the unreferenced data store and blob will become sweep ready and will show up as deleted in GC stats. There was a change few months back that changed the logic to add sweep ready objects as deleted even when sweep is enabled (https://github.com/microsoft/FluidFramework/pull/19524) and the test probably became flaky then.
Fix
Broke the test above into 2:
AB#8350