Closed seanimam closed 1 month ago
Probably worth noting in the PR description that the build:client
pipeline already explicitly runs webpack in that package, so we aren't losing any validation coverage here. We just no longer run the webpack build as a part of the standard build
script.
Stage here for reference: https://dev.azure.com/fluidframework/public/_build/results?buildId=280829&view=logs&j=3dc8fd7e-4368-5a92-293e-d53cefc8c4b3&t=2707fe12-f442-5599-18cb-7fe97270bcb8
Metric Name | Baseline Size | Compare Size | Size Diff |
---|---|---|---|
aqueduct.js | 460.46 KB | 460.5 KB | ⯅ +35 Bytes |
azureClient.js | 557.66 KB | 557.71 KB | ⯅ +49 Bytes |
connectionState.js | 680 Bytes | 680 Bytes | ■ No change |
containerRuntime.js | 261.1 KB | 261.12 KB | ⯅ +14 Bytes |
fluidFramework.js | 409.19 KB | 409.21 KB | ⯅ +14 Bytes |
loader.js | 134.04 KB | 134.05 KB | ⯅ +14 Bytes |
map.js | 42.13 KB | 42.14 KB | ⯅ +7 Bytes |
matrix.js | 146.46 KB | 146.46 KB | ⯅ +7 Bytes |
odspClient.js | 525.81 KB | 525.85 KB | ⯅ +49 Bytes |
odspDriver.js | 97.55 KB | 97.57 KB | ⯅ +21 Bytes |
odspPrefetchSnapshot.js | 42.61 KB | 42.62 KB | ⯅ +14 Bytes |
sharedString.js | 163.18 KB | 163.19 KB | ⯅ +7 Bytes |
sharedTree.js | 399.71 KB | 399.71 KB | ⯅ +7 Bytes |
Total Size | 3.31 MB | 3.31 MB | ⯅ +245 Bytes |
Baseline commit: e8955579f6d52a6c7e300642088c60d6ed12d7db
Generated by :no_entry_sign: dangerJS against ecc931940f1632e58f9686b1d984551fe6c4072e
Latest commit: ecc931940f1632e58f9686b1d984551fe6c4072e
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Description
Removes webpack from the fluid build task step of the devtools browser extension package