Fix considering versions > 2.0.0 as semver

[tyler-cai-microsoft]

AB#8967

This should fix test branches and allow them to build again.

[tyler-cai-microsoft]

These changes don't seem in line with the internal version scheme. Can you clarify what the problem is and how this fixes it?

Yes, right now test branches are failing to finish their builds because when they are testing, their branches come out as Error: Couldn't convert 2.1.0-280913-test to a standard semver. 2.1.0-280913-test is not internal, but it is being treated as such, what do we want to do here?

My assumption currently is that we are moving off the x.y.z-internal.a.b.c naming scheme, for example this

[tylerbutler]

My assumption currently is that we are moving off the x.y.z-internal.a.b.c naming scheme

We are, but that doesn't change how the scheme is defined. As it is this change makes 3.0.0-internal.1.0.0 not parse as internal, but it should. You shouldn't need to remove existing test cases.

It's also not clear to me what is producing these 2.1.0-280913-test versions. Those are not version numbers produced by the CI system AFAIK. Test builds should be of the form 0.0.0-280913-test (I don't like it, but that's the scheme). Do you know what's producing this version string?

What is the calling code trying to do and what version strings does it have available to work with? We might need new functions depending on what the code is trying to do.

FYI @sonalideshpandemsft @scottn12

[markfields]

@tyler-cai-microsoft / @tylerbutler -- Should we close this as dupe of #22030?

[tyler-cai-microsoft]

Closing as it's a dupe