Another entry in the Never Ending Story of cleaning up Nexus memory leaks. For some reason, this listener leak did not appear in local FRS and Routerlicious runs; however, it was easily reproduced in a deployed FRS instance.
Breaking Changes
A few types have had .off() instance methods added to them to allow Nexus to properly clean up the listener that it adds.
Reviewer Guidance
Hopefully will come back to making the "dispose" flow a bit cleaner, but this seems good enough for now
Description
Another entry in the Never Ending Story of cleaning up Nexus memory leaks. For some reason, this listener leak did not appear in local FRS and Routerlicious runs; however, it was easily reproduced in a deployed FRS instance.
Breaking Changes
A few types have had
.off()instance methods added to them to allow Nexus to properly clean up the listener that it adds.Reviewer Guidance
Hopefully will come back to making the "dispose" flow a bit cleaner, but this seems good enough for now