microsoft / FluidFramework

Library for building distributed, real-time collaborative web applications
https://fluidframework.com
MIT License
4.7k stars 528 forks source link

fix(ci): Fix hanging perf benchmarks for container-runtime #21952

Closed alexvy86 closed 1 month ago

alexvy86 commented 1 month ago

Description

The perf tests for the container-runtime package are hanging (not done after 4h44m in the most recent run) and causing the perf benchmarks pipeline runs to get cancelled by ADO. This PR fixes them by adding a missing --exit flag.

Note: ideally the flag should not be necessary but we don't know why these (and a few other packages in the repo) need it when running tests to not hang. The normal mocha test scripts in this package already had it.

Reviewer Guidance

The review process is outlined on this wiki page.

AB#9074

azure-boards[bot] commented 1 month ago

✅ Successfully linked to Azure Boards work item(s):

msfluid-bot commented 1 month ago
@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 457.6 KB 457.63 KB +35 Bytes
azureClient.js 555.37 KB 555.42 KB +49 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 258.68 KB 258.7 KB +14 Bytes
fluidFramework.js 405.62 KB 405.63 KB +14 Bytes
loader.js 134.08 KB 134.09 KB +14 Bytes
map.js 42.17 KB 42.18 KB +7 Bytes
matrix.js 145.68 KB 145.69 KB +7 Bytes
odspClient.js 523.52 KB 523.57 KB +49 Bytes
odspDriver.js 97.55 KB 97.57 KB +21 Bytes
odspPrefetchSnapshot.js 42.61 KB 42.62 KB +14 Bytes
sharedString.js 162.69 KB 162.7 KB +7 Bytes
sharedTree.js 396.13 KB 396.14 KB +7 Bytes
Total Size 3.3 MB 3.3 MB +245 Bytes

Baseline commit: a8d7dfdaa4da7ce282f96e3f9f3685d305393ae1

Generated by :no_entry_sign: dangerJS against bb2a4e499c6eaaf661e0562e71b4b1f83db37945