microsoft / FluidFramework

Library for building distributed, real-time collaborative web applications
https://fluidframework.com
MIT License
4.7k stars 528 forks source link

tree: Avoid adding an empty changeset to compositions #21958

Closed alex-pardes closed 1 month ago

alex-pardes commented 1 month ago

Description

This PR removes a behavior where ModularChangeFamily, as well as some test change handlers, would include an empty changeset into the composition whenever composing an array of changesets. This was done so that even composing a single changeset would cause a full composition pass. In the past this was necessary because the composition pass had the side effect of inlining revision tags. Now that revision tag inlining is done separately, this pass is unnecessary.

msfluid-bot commented 1 month ago
@fluid-example/bundle-size-tests: +65 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 457.46 KB 457.5 KB +35 Bytes
azureClient.js 555.23 KB 555.28 KB +49 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 258.67 KB 258.68 KB +14 Bytes
fluidFramework.js 406.02 KB 405.95 KB -76 Bytes
loader.js 134.04 KB 134.05 KB +14 Bytes
map.js 42.13 KB 42.14 KB +7 Bytes
matrix.js 145.61 KB 145.62 KB +7 Bytes
odspClient.js 523.37 KB 523.42 KB +49 Bytes
odspDriver.js 97.55 KB 97.57 KB +21 Bytes
odspPrefetchSnapshot.js 42.61 KB 42.62 KB +14 Bytes
sharedString.js 162.62 KB 162.63 KB +7 Bytes
sharedTree.js 396.54 KB 396.46 KB -83 Bytes
Total Size 3.3 MB 3.3 MB +65 Bytes

Baseline commit: a58b992c0c64b9d12cf62cec41f39d3e1a8f2373

Generated by :no_entry_sign: dangerJS against e5c77ae8401b3cec7200844440f97d6fa81e11ba