microsoft / FluidFramework

Library for building distributed, real-time collaborative web applications
https://fluidframework.com
MIT License
4.73k stars 532 forks source link

Add document URL to test and stress telemetry #22344

Closed Abe27342 closed 1 month ago

Abe27342 commented 2 months ago

Description

Adds telemetry events that identify the document which e2e tests & stress tests against odsp real services operate against.

This makes it possible to retrieve enough information from telemetry to use fetch-tool on problematic runs.

Reviewer Guidance

The main concern I have with this PR is around privacy concerns; this type of information is obviously a huge privacy no-no for production-like codepaths. I believe this concern is mitigated by

  1. Only placing log statements in test code
  2. Tagging such data correctly as user data

but if there are any further steps we can take I'm open to them. AB#12331

msfluid-bot commented 2 months ago
@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 460.47 KB 460.5 KB +35 Bytes
azureClient.js 557.45 KB 557.5 KB +49 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 259.74 KB 259.76 KB +14 Bytes
fluidFramework.js 405.32 KB 405.33 KB +14 Bytes
loader.js 134.34 KB 134.36 KB +14 Bytes
map.js 42.46 KB 42.46 KB +7 Bytes
matrix.js 148.63 KB 148.64 KB +7 Bytes
odspClient.js 524.41 KB 524.46 KB +49 Bytes
odspDriver.js 97.84 KB 97.86 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.82 KB +14 Bytes
sharedString.js 164.82 KB 164.83 KB +7 Bytes
sharedTree.js 395.78 KB 395.78 KB +7 Bytes
Total Size 3.31 MB 3.31 MB +245 Bytes

Baseline commit: f8025cc2d271bd1187ae439d51fd5e6404a98b17

Generated by :no_entry_sign: dangerJS against c25aa6ed5a3bfc1fb5a669ab2db9f859ff1188e8