microsoft / FluidFramework

Library for building distributed, real-time collaborative web applications
https://fluidframework.com
MIT License
4.73k stars 532 forks source link

(fix) ItExpects exception for OpRoundtripTime error log is using an old eventName #22353

Closed markfields closed 2 months ago

markfields commented 2 months ago

Description

The fix: The event name changed at some point but this wasn't updated.

Background: This is a convenience especially when debugging - this event will fail many itExpects tests if you pause the debugger on a breakpoint. It only triggers after 5s, no test should be depending on this behavior (way too slow of a test strategy).

msfluid-bot commented 2 months ago
@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 459.92 KB 459.95 KB +35 Bytes
azureClient.js 557.96 KB 558.01 KB +49 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 260.75 KB 260.76 KB +14 Bytes
fluidFramework.js 398.48 KB 398.5 KB +14 Bytes
loader.js 134.26 KB 134.28 KB +14 Bytes
map.js 42.39 KB 42.39 KB +7 Bytes
matrix.js 146.56 KB 146.56 KB +7 Bytes
odspClient.js 525.23 KB 525.28 KB +49 Bytes
odspDriver.js 97.72 KB 97.74 KB +21 Bytes
odspPrefetchSnapshot.js 42.78 KB 42.79 KB +14 Bytes
sharedString.js 163.26 KB 163.26 KB +7 Bytes
sharedTree.js 389 KB 389 KB +7 Bytes
Total Size 3.29 MB 3.29 MB +245 Bytes

Baseline commit: d1c28f8195e672ef6c8729064b267256f111c222

Generated by :no_entry_sign: dangerJS against 6b630e0f1f29516e2d805ac8428907835481092e