Closed jason-ha closed 2 months ago
pre-approved for when it passes ci
Metric Name | Baseline Size | Compare Size | Size Diff |
---|---|---|---|
aqueduct.js | 459.92 KB | 459.95 KB | ⯅ +35 Bytes |
azureClient.js | 557.96 KB | 558.01 KB | ⯅ +49 Bytes |
connectionState.js | 680 Bytes | 680 Bytes | ■ No change |
containerRuntime.js | 260.75 KB | 260.76 KB | ⯅ +14 Bytes |
fluidFramework.js | 398.48 KB | 398.5 KB | ⯅ +14 Bytes |
loader.js | 134.26 KB | 134.28 KB | ⯅ +14 Bytes |
map.js | 42.39 KB | 42.39 KB | ⯅ +7 Bytes |
matrix.js | 146.56 KB | 146.56 KB | ⯅ +7 Bytes |
odspClient.js | 525.23 KB | 525.28 KB | ⯅ +49 Bytes |
odspDriver.js | 97.72 KB | 97.74 KB | ⯅ +21 Bytes |
odspPrefetchSnapshot.js | 42.78 KB | 42.79 KB | ⯅ +14 Bytes |
sharedString.js | 163.26 KB | 163.26 KB | ⯅ +7 Bytes |
sharedTree.js | 389 KB | 389 KB | ⯅ +7 Bytes |
Total Size | 3.29 MB | 3.29 MB | ⯅ +245 Bytes |
Baseline commit: d533e80c4e2975a07ec3edf50498e3ed8c2e7716
Generated by :no_entry_sign: dangerJS against ae3cf5e7fdef7ca629081e39c1e00a6c17af451f
You should put this under packages/framework/presence rather than experimental/framework/presence. Saves you a directory move later and the experimental/ directory is useless anyway (all packages should really be moved to their appropriate homes now even).
Also run pnpm layer-check --md .
to generate an updated PACKAGES.md
You should put this under packages/framework/presence rather than experimental/framework/presence. Saves you a directory move later and the experimental/ directory is useless anyway (all packages should really be moved to their appropriate homes now even).
I am not worried about a later directory move. Are we sure about experimental directory being useless? I personally leverage that today. I exclude that path in searches to avoid sketchy hits. Though I am hoping this package is less sketchy and would want in more of my searches.
I am not worried about a later directory move. Are we sure about experimental directory being useless? I personally leverage that today. I exclude that path in searches to avoid sketchy hits. Though I am hoping this package is less sketchy and would want in more of my searches.
Depending on why you're searching, excluding experimental is probably not safe since there are long-term-supported packages in there (i.e. PropertyDDS) to consider. And similarly, you probably want other developers to be considering your package if/when they make horizontal changes.
Historically I've also seen folks make bad layering decisions in particular when living outside of the normal directory structure. Theoretically layerInfo should handle this and protect appropriately, but I don't trust that we maintain layering as cautiously outside of the main packages subdirectory.
🔗 No broken links found! ✅
Your attention to detail is admirable.
> fluidframework-docs@0.25.0 ci:linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test ci:start 1313 linkcheck:full
1: starting server using command "npm run ci:start"
and when url "[ 'http://127.0.0.1:1313' ]" is responding with HTTP status code 200
running tests using command "npm run linkcheck:full"
> fluidframework-docs@0.25.0 ci:start
> http-server ./public --port 1313 --silent
> fluidframework-docs@0.25.0 linkcheck:full
> npm run linkcheck:fast -- --external
> fluidframework-docs@0.25.0 linkcheck:fast
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt --external
Crawling...
Stats:
378015 links
2980 destination URLs
2 URLs ignored
0 warnings
0 errors
empty private shell package
AB#7915