microsoft / FluidFramework

Library for building distributed, real-time collaborative web applications
https://fluidframework.com
MIT License
4.71k stars 531 forks source link

Remove dead ordered client election code #22488

Open tyler-cai-microsoft opened 6 days ago

tyler-cai-microsoft commented 6 days ago

AB#15192

Removes dead code from OrderedClientElection.

Historical note: we had developed a feature that elected a new summarizer client when the current summarizer client was failing to summarize. When we shipped the feature and turned it on, we ran into many buggy issues with multiple summarizers. Since then, we've turned off the feature and have some dead code. This PR aims to remove that dead code.

msfluid-bot commented 6 days ago
@fluid-example/bundle-size-tests: -1.13 KB
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 460.26 KB 459.95 KB -315 Bytes
azureClient.js 558.25 KB 557.95 KB -301 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 261.02 KB 260.7 KB -336 Bytes
fluidFramework.js 401.41 KB 401.42 KB +14 Bytes
loader.js 134.24 KB 134.25 KB +14 Bytes
map.js 42.43 KB 42.44 KB +7 Bytes
matrix.js 146.58 KB 146.58 KB +7 Bytes
odspClient.js 525.54 KB 525.24 KB -301 Bytes
odspDriver.js 97.85 KB 97.87 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.82 KB +14 Bytes
sharedString.js 163.3 KB 163.31 KB +7 Bytes
sharedTree.js 391.87 KB 391.88 KB +7 Bytes
Total Size 3.3 MB 3.3 MB -1.13 KB

Baseline commit: cb7861c4cb9c3650feeda3ca4408f2681f20e9c9

Generated by :no_entry_sign: dangerJS against fc2e48a59bbd09f16c28a19f42471c36b34ea440