anthony-murphy
commented
1 week ago can there be a test added for this? regression tests are some of the best tests, as things that break tend to be non-obvious so frequently break again
Closed jason-ha closed 1 week ago
anthony-murphy
commented
1 week ago can there be a test added for this? regression tests are some of the best tests, as things that break tend to be non-obvious so frequently break again
jason-ha
commented
1 week ago can there be a test added for this? regression tests are some of the best tests, as things that break tend to be non-obvious so frequently break again
There are tests pending which is how we caught this. We wanted typescript to detect this problem for us :/
msfluid-bot
commented
1 week ago | Metric Name | Baseline Size | Compare Size | Size Diff |
|---|---|---|---|
| aqueduct.js | 467.2 KB | 467.23 KB | ⯅ +35 Bytes |
| azureClient.js | 563.97 KB | 564.01 KB | ⯅ +49 Bytes |
| connectionState.js | 724 Bytes | 724 Bytes | ■ No change |
| containerRuntime.js | 263.39 KB | 263.4 KB | ⯅ +14 Bytes |
| fluidFramework.js | 427.12 KB | 427.13 KB | ⯅ +14 Bytes |
| loader.js | 134.18 KB | 134.19 KB | ⯅ +14 Bytes |
| map.js | 42.71 KB | 42.71 KB | ⯅ +7 Bytes |
| matrix.js | 150.15 KB | 150.16 KB | ⯅ +7 Bytes |
| odspClient.js | 529.8 KB | 529.85 KB | ⯅ +49 Bytes |
| odspDriver.js | 97.88 KB | 97.9 KB | ⯅ +21 Bytes |
| odspPrefetchSnapshot.js | 42.81 KB | 42.83 KB | ⯅ +14 Bytes |
| sharedString.js | 166.23 KB | 166.24 KB | ⯅ +7 Bytes |
| sharedTree.js | 417.58 KB | 417.58 KB | ⯅ +7 Bytes |
| Total Size | 3.38 MB | 3.38 MB | ⯅ +245 Bytes |
Baseline commit: 87261f6a8340949d3c2e1ae156079c21533ac087
Generated by :no_entry_sign: dangerJS against a8f4cf5ab161dd41e9b9bedb3e9eab448fe7ec58
Corrects regression from #23120