Closed noencke closed 1 week ago
Metric Name | Baseline Size | Compare Size | Size Diff |
---|---|---|---|
aqueduct.js | 467.24 KB | 467.27 KB | ⯅ +35 Bytes |
azureClient.js | 564.01 KB | 564.06 KB | ⯅ +49 Bytes |
connectionState.js | 724 Bytes | 724 Bytes | ■ No change |
containerRuntime.js | 263.43 KB | 263.45 KB | ⯅ +14 Bytes |
fluidFramework.js | 427.22 KB | 428.32 KB | ⯅ +1.1 KB |
loader.js | 134.18 KB | 134.19 KB | ⯅ +14 Bytes |
map.js | 42.71 KB | 42.71 KB | ⯅ +7 Bytes |
matrix.js | 150.15 KB | 150.16 KB | ⯅ +7 Bytes |
odspClient.js | 529.85 KB | 529.89 KB | ⯅ +49 Bytes |
odspDriver.js | 97.88 KB | 97.9 KB | ⯅ +21 Bytes |
odspPrefetchSnapshot.js | 42.81 KB | 42.83 KB | ⯅ +14 Bytes |
sharedString.js | 166.23 KB | 166.24 KB | ⯅ +7 Bytes |
sharedTree.js | 417.68 KB | 418.77 KB | ⯅ +1.09 KB |
Total Size | 3.38 MB | 3.38 MB | ⯅ +2.41 KB |
Baseline commit: 421ba403750ecf86da0490a9805bf2bef8573243
Generated by :no_entry_sign: dangerJS against 4613843e19b5440c7c91ca9cfc7e24b8c1e7b232
Description
This tightens the state machine space for
BranchCommitEnricher
and makes various simplifications to the API and code.The API surface of
BranchCommitEnricher
is reduced to functions that:Item (i) used to be made of a few different methods whose invocations needed to be coordinated by
SharedTreeCore
. Now,BranchCommitEnricher
manages this internally. Previously, it needed to know whether or not the commit being submitted was the commit of the outermost transaction. This could be problematic for future refactors of SharedTreeCore, so the enricher now derives that information from its internals (since it already keeps track of ongoing transactions via theTransactionEnricher
.