microsoft / FluidFramework

Library for building distributed, real-time collaborative web applications
https://fluidframework.com
MIT License
4.74k stars 536 forks source link

Fix areOnlyKeys handling of optional fields #23152

Closed CraigMacomber closed 1 week ago

CraigMacomber commented 1 week ago

Description

Fix areOnlyKeys handling of optional fields, add tests for it, and document issue with index signatures.

Reviewer Guidance

The review process is outlined on this wiki page.

msfluid-bot commented 1 week ago
@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 467.24 KB 467.27 KB +35 Bytes
azureClient.js 564.01 KB 564.06 KB +49 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 263.43 KB 263.45 KB +14 Bytes
fluidFramework.js 427.22 KB 427.23 KB +14 Bytes
loader.js 134.18 KB 134.19 KB +14 Bytes
map.js 42.71 KB 42.71 KB +7 Bytes
matrix.js 150.15 KB 150.16 KB +7 Bytes
odspClient.js 529.85 KB 529.89 KB +49 Bytes
odspDriver.js 97.88 KB 97.9 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.83 KB +14 Bytes
sharedString.js 166.23 KB 166.24 KB +7 Bytes
sharedTree.js 417.68 KB 417.68 KB +7 Bytes
Total Size 3.38 MB 3.38 MB +245 Bytes

Baseline commit: 86ee6ad7bb23ea1d50c4d31c9385a12fc99fefbd

Generated by :no_entry_sign: dangerJS against bfe7266be50e64f077cbdb925ebac9a8422a4ca7