msfluid-bot
commented
5 days ago ⯅ @fluid-example/bundle-size-tests: +245 Bytes
| Metric Name | Baseline Size | Compare Size | Size Diff |
|---|---|---|---|
| aqueduct.js | 467.24 KB | 467.27 KB | ⯅ +35 Bytes |
| azureClient.js | 564.01 KB | 564.06 KB | ⯅ +49 Bytes |
| connectionState.js | 724 Bytes | 724 Bytes | ■ No change |
| containerRuntime.js | 263.43 KB | 263.45 KB | ⯅ +14 Bytes |
| fluidFramework.js | 428.31 KB | 428.32 KB | ⯅ +14 Bytes |
| loader.js | 134.18 KB | 134.19 KB | ⯅ +14 Bytes |
| map.js | 42.71 KB | 42.71 KB | ⯅ +7 Bytes |
| matrix.js | 150.15 KB | 150.16 KB | ⯅ +7 Bytes |
| odspClient.js | 529.85 KB | 529.89 KB | ⯅ +49 Bytes |
| odspDriver.js | 97.88 KB | 97.9 KB | ⯅ +21 Bytes |
| odspPrefetchSnapshot.js | 42.81 KB | 42.83 KB | ⯅ +14 Bytes |
| sharedString.js | 166.23 KB | 166.24 KB | ⯅ +7 Bytes |
| sharedTree.js | 418.76 KB | 418.77 KB | ⯅ +7 Bytes |
| Total Size | 3.38 MB | 3.38 MB | ⯅ +245 Bytes |
Baseline commit: 6330f4a6876501f61a9569de88d237a326904fa2
Generated by :no_entry_sign: dangerJS against 0cc5bc6d8a7b6b34b119a3baf277f0158c3e7764
AB#25115 AB#25119
Some of my recent changes introduced two regressions:
22956 - In that PR I thought I didn't need to unmount the root, but this meant that the input fields were not running their unmount scripts and were still tied to the old container's SharedStrings (and so would throw an error if you tried to edit them after migration). There might be an alternative approach to re-render more appropriately, but this PR takes the more straightforward route by more-closely approximating the ReactDOM behavior.
22194 - In that PR I remembered to update the
migrationToolon"migrated"for the tinylicious version, but not the test version. As a result the test version would show the old container's migration state after migration completed.