microsoft / FluidFramework

Library for building distributed, real-time collaborative web applications
https://fluidframework.com
MIT License
4.74k stars 535 forks source link

improvement(eslint-config-fluid): Update `@typescript-eslint/consistent-type-exports` auto-fix behavior #23188

Closed Josmithr closed 3 days ago

Josmithr commented 3 days ago

Updates auto-fix policy for @typescript-eslint/consistent-type-exports to prefer inline type annotations, rather than splitting exports into type-only and non-type-only groups. This makes it easier to tell at a glance how the auto-fix changes affect individual exports when a list of exports is large. It also makes it easier to detect issues in edge-cases where the the rule is applied incorrectly.

E.g.:

export { type Foo, Bar } from "./baz.js";

instead of:

export type { Foo } from "./baz.js";
export { Bar } from "./baz.js";

AB#22618

github-actions[bot] commented 3 days ago

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"

> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  170005 links
    1595 destination URLs
    1825 URLs ignored
       0 warnings
       0 errors