msfluid-bot
commented
3 days ago ⯅ @fluid-example/bundle-size-tests: +245 Bytes
| Metric Name | Baseline Size | Compare Size | Size Diff |
|---|---|---|---|
| aqueduct.js | 467.26 KB | 467.3 KB | ⯅ +35 Bytes |
| azureClient.js | 564.03 KB | 564.08 KB | ⯅ +49 Bytes |
| connectionState.js | 724 Bytes | 724 Bytes | ■ No change |
| containerRuntime.js | 263.45 KB | 263.47 KB | ⯅ +14 Bytes |
| fluidFramework.js | 429.04 KB | 429.05 KB | ⯅ +14 Bytes |
| loader.js | 134.18 KB | 134.19 KB | ⯅ +14 Bytes |
| map.js | 42.71 KB | 42.71 KB | ⯅ +7 Bytes |
| matrix.js | 150.15 KB | 150.16 KB | ⯅ +7 Bytes |
| odspClient.js | 530.39 KB | 530.44 KB | ⯅ +49 Bytes |
| odspDriver.js | 98.41 KB | 98.43 KB | ⯅ +21 Bytes |
| odspPrefetchSnapshot.js | 42.81 KB | 42.83 KB | ⯅ +14 Bytes |
| sharedString.js | 166.23 KB | 166.24 KB | ⯅ +7 Bytes |
| sharedTree.js | 419.49 KB | 419.5 KB | ⯅ +7 Bytes |
| Total Size | 3.38 MB | 3.38 MB | ⯅ +245 Bytes |
Baseline commit: c025b53f3b007117c0338f3badb34d14b6175f92
Generated by :no_entry_sign: dangerJS against 7cc0f8d8504b27f92228977ae9330c7d71446d61
alexvy86
Description
Fixes the tests of the external-data example so they succeed in Node20.
Also simplifies that package a bit by removing an unnecessary split of the webpack config and removing the unused
stream-httpdependency.I also tried to simplify further by replacing node-fetch with Node's native fetch but that led to different test failures. Not urgent so I left it alone.
Reviewer Guidance
The review process is outlined on this wiki page.
I confirmed the tests pass in Node18 and Node20.
AB#20804