microsoft / FluidFramework

Library for building distributed, real-time collaborative web applications
https://fluidframework.com
MIT License
4.72k stars 532 forks source link

Code syntax highlighting does not meet contrast requirements #3347

Closed micahgodbolt closed 4 years ago

micahgodbolt commented 4 years ago

The green on gray syntax highlighting isn't passing accessibility contrast ratios.

image image

options:

  1. run hugo gen chromastyles --style=tango > syntax.css and load the 82 lines of CSS that gets generated (tweaking the green )
  2. Use a different theme like Monokai, Dracula, Rainbow Dash or VS

image

image

image

image

mattetti commented 4 years ago

I'd say that if vs passes the accessibility tests, we should switch to it. I personally like monokai because I like strong contrast between code and test but that's a personal preference. @DanWahlin any suggestions?