microsoft / GLUECoS

A benchmark for code-switched NLP, ACL 2020
https://microsoft.github.io/GLUECoS
MIT License
74 stars 57 forks source link

add Azure region option #6

Closed rohanrajpal closed 4 years ago

rohanrajpal commented 4 years ago

Currently, Azure translator region is hardcoded and breaks if we use another Azure region. This PR fixes issue #5

ghost commented 4 years ago

CLA assistant check
All CLA requirements met.

Genius1237 commented 4 years ago

@rohanrajpal Which region did you test this out with? It looks like they've changed something in the backend recently. The key I've used is set to the global region and it works by just removing southeastasia from https://github.com/microsoft/GLUECoS/blob/19fb6713ad2d22d181647db4aa2bd2c76aea4270/transliterator.py#L13

Can you check if this works for you? I do not think that any of the other changes you've made are needed

rohanrajpal commented 4 years ago

@rohanrajpal Which region did you test this out with? It looks like they've changed something in the backend recently. The key I've used is set to the global region and it works by just removing southeastasia from

https://github.com/microsoft/GLUECoS/blob/19fb6713ad2d22d181647db4aa2bd2c76aea4270/transliterator.py#L13

Can you check if this works for you? I do not think that any of the other changes you've made are needed

The key I've set is to the eastasia region and it does not work if I remove southeastasia.

rohanrajpal commented 4 years ago

so my guess is that the instructions should be region based then, also sorry for the late reply

Genius1237 commented 4 years ago

Hmm. All of this seems to be a bit confusing. I'll just update the docs specifying that the key generated belong to the global region.

If the version of code you have works with your key, I would suggest that you use it as is. This is a minor aspect to worry too much about.