[cmake] GSL.natvis issues

microsoft / GSL

Guidelines Support Library

Other

6.13k stars 737 forks source link

Closed jpr42 closed 1 year ago

jpr42 commented 1 year ago

Minor problems with the GLS.natvis CMake support

[x] find_package isn't supported (IE vpckg, conan, system package managers) don't benefit from GSL.natvis
- GSL.natvis isn't installed
[x] Ninja on MSVC isn't supported
- https://discourse.cmake.org/t/does-adding-natvis-files-via-target-sources-work-on-ninja/7316
- This can be solved elegantly with target_link_options (3.13+)

dmitrykobets-msft commented 1 year ago

@jpr42 is this issue resolved in #1083?

jpr42 commented 1 year ago

@jpr42 is this issue resolved in #1083?

No. I don't have access to a Windows machine so I haven't been able to tackle it.

jpr42 commented 1 year ago

I recently obtained a Windows laptop. I'll be able to tackle this issue soon.