Update Clang GSL_SUPPRESS to stringize parameter instead of using fixed string literal.

microsoft / GSL

Guidelines Support Library

Other

6.11k stars 736 forks source link

Update Clang GSL_SUPPRESS to stringize parameter instead of using fixed string literal. #1133

Closed edgchen1 closed 11 months ago

edgchen1 commented 1 year ago

Fix #1130.

dmitrykobets-msft commented 12 months ago

@edgchen1 it looks like gsl/byte also had a definition of GSL_SUPPRESS. After digging into it, the redefinition doesn't look necessary. I've created a pull request https://github.com/edgchen1/GSL/pull/1 into your fork with the necessary changes to hopefully fix the failing tests.

edgchen1 commented 12 months ago

@edgchen1 it looks like gsl/byte also had a definition of GSL_SUPPRESS. After digging into it, the redefinition doesn't look necessary. I've created a pull request edgchen1#1 into your fork with the necessary changes to hopefully fix the failing tests.

Thanks! Merged your fix.

dmitrykobets-msft commented 11 months ago

Hi @edgchen1 sorry in the delay in getting this merged; our CI was having some issues that are now resolved. Thanks for the fix, merging.