search

microsoft / GSL

Guidelines Support Library
Other
6.11k stars 736 forks source link

MSVC: Recent commits break compilation #1147

Open diamante0018 opened 6 months ago

diamante0018 commented 6 months ago

Hello, I'm afraid one of the most recent commits has broken on MSVC as it now triggers some warnings.

The following does remind me a lot of the first issue I opened on this repo some time ago as it too was an issue with the MSVC preprocessor and the min/max macros. Maybe this is similar?

Dear maintainers, please consider adding an MSVC workflow that tests this repo. I only see one for Android and Ubuntu (Linux)

Error: D:\a\DisablePlutoChat\DisablePlutoChat\deps\GSL\include\gsl\util(44,40): error C[22](https://github.com/diamante0018/DisablePlutoChat/actions/runs/8058374482/job/22011065160#step:6:23)20: the following warning is treated as an error [D:\a\DisablePlutoChat\DisablePlutoChat\build\common.vcxproj]
  (compiling source file '../src/common/utils/thread.cpp')

Warning: D:\a\DisablePlutoChat\DisablePlutoChat\deps\GSL\include\gsl\util(44,40): warning C4067: unexpected tokens following preprocessor directive - expected a newline [D:\a\DisablePlutoChat\DisablePlutoChat\build\common.vcxproj]
  (compiling source file '../src/common/utils/thread.cpp')

Warning: D:\a\DisablePlutoChat\DisablePlutoChat\deps\GSL\include\gsl\util(163,40): warning C4067: unexpected tokens following preprocessor directive - expected a newline [D:\a\DisablePlutoChat\DisablePlutoChat\build\common.vcxproj]
  (compiling source file '../src/common/utils/thread.cpp')

Warning: D:\a\DisablePlutoChat\DisablePlutoChat\deps\GSL\include\gsl\span(67,40): warning C4067: unexpected tokens following preprocessor directive - expected a newline [D:\a\DisablePlutoChat\DisablePlutoChat\build\common.vcxproj]
  (compiling source file '../src/common/utils/thread.cpp')

Warning: D:\a\DisablePlutoChat\DisablePlutoChat\deps\GSL\include\gsl\span(855,40): warning C4067: unexpected tokens following preprocessor directive - expected a newline [D:\a\DisablePlutoChat\DisablePlutoChat\build\common.vcxproj]
  (compiling source file '../src/common/utils/thread.cpp')