Open Mq-b opened 3 months ago
No change requested - Instead of implicit or explicit noexcept(false)
, would it be better to use conditional noexcept
here?
@Mq-b There appears to be problems with the checks running on older PRs. Can you please push an empty commit to retrigger tests.
I thought this was some kind of code specification at first, but I searched the entire repository and only saw this one use of
noexcept(false)
. I don't think that's necessary here,narrow
is not a destructor.I looked at other gsl libraries and didn't see 'noexcept(false)' used either.
https://github.com/gsl-lite/gsl-lite/blob/bd9eb162d42d8ae6a7e86902ca7060247d71ac41/include/gsl/gsl-lite.hpp#L2532