microsoft / GalaxyExplorer

Galaxy Explorer is the application Microsoft is building as part of the Share Your Idea campaign.
MIT License
947 stars 331 forks source link

Added content : Galactic Center #41

Closed elitemn closed 8 years ago

elitemn commented 8 years ago

Added a new POI named "Galactic Center" with new associated views based on the Solar System view. Added voice overs and commentary for the new views. Please review and let me know what you think.

msftclas commented 8 years ago

Hi @elitemn, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

msftclas commented 8 years ago

@elitemn, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

timGerken commented 8 years ago

@elitemn it looks like this is the beginning of some pretty cool new content!

Some things I noticed:

When in Galaxy view:

  1. On the POI card for Galactic Center, the subtext "Sagittarius A" is clipped/illegible

When in GalaxyCenter view:

  1. S102 does not appear to exactly follow its orbit
  2. S102_LOD1 seems to be way too big and orbits with S102 like a massive halo
  3. S102's speed combined with its color causes color separation (red/green) during most of its orbit.
  4. S2's orbit is "very pointy" where it is nearest Sagittarius A*
  5. On the POI card for Sagittarius A*, the subtext "Complex Radio Source (Supermassive Black Hole)" is clipped/illegible
  6. The True-scale POI should be removed as its VO is still that for the Solar System
  7. The lines from the POI cards for both S2 and S102 do not touch their orbits (as they do in SolarSystem view)
elitemn commented 8 years ago

@timGerken Thanks for the great feedback! I'll dig in and see what I can learn.

timGerken commented 8 years ago

Looking better!

Some things I noticed:

timGerken commented 8 years ago

One more thing:

elitemn commented 8 years ago

I get a ratio of .71875 (.719) according to this research supplement from UCLA: Supplement (Table S4 page 10). I believe this measurement is newer and more precise than the Wikipedia entry (2002) because I find reference to measurements recorded in 2011 (page 3, last paragraph). I did round the orbital period from 16.17 years to 16 years in my calculation. If we are going to be that precise, I suggest we change to .712 (11.5/16.17). What are your thoughts?

timGerken commented 8 years ago

I'm in favor of the more current research :) Go ahead and update both Period (what is currently used in the scene) and Period Real (what would be used if "Realistic View" were implemented) to reflect that change.

timGerken commented 8 years ago

Hi @elitemn, thanks for making all of these updates! There are two more things I noticed today, though I think we are getting close.

Keep up the great work!

elitemn commented 8 years ago

Thanks again Tim for the keen eye. I will have to think about the starting positions of the galactic center stars. These positions are calculated based off the orbital values entered and the current time (from what I understand at this point). Perhaps instead of messing with the orbital mechanics, I could adjust the starting zoom level to be more appropriate.

timGerken commented 8 years ago

Another option, though a bit more complex, would be to add a directional indicator to the POI marker that points to where to actually find the sun/planet.

That's additional functionality that is outside of the scope of this PR. It would make more sense to start with changing the default scale of the Sagittarius A* scene and do the POI/DI implementation as a separate PR.

elitemn commented 8 years ago

@timGerken Done, also reverted orbit speed back to 100 to better illustrate the rate at which this monster at the center of our galaxy is whipping stars around.

timGerken commented 8 years ago

love it!