search

microsoft / GalaxyExplorer

Galaxy Explorer is the application Microsoft is building as part of the Share Your Idea campaign.
MIT License
947 stars 331 forks source link

Commented out addition of code to turn off UseSpericalConeSearch when… #81

Closed elitemn closed 7 years ago

elitemn commented 7 years ago

… VR device is not present. fixes issue #80.

elitemn commented 7 years ago

Yes indeed, I knew you must have done that for a reason. Your solution works with the HoloLens emulator as well, but I can't help but wonder if we should be setting the if statement to phone device rather than "if VR device not present" and if "Not in Unity_Editor". What about something like "If device = mobile" or "screensize < x" then set UseSphericalConeSearch = false. It seems to me that the "UseSphericalConeSearch = false" should only be set when in a small screen, am I thinking about that right?

timGerken commented 7 years ago

I don’t think it is just a resolution thing. My phone’s resolution is 1440x2560 (portrait) which is higher than my desktop (1920x1200) or my original Surface Pro (1920x1080). I think we might need a “PlatformManager” class attached somewhere to the CoreSystems.unity scene that knows how to do “the right things” for various resolutions and form factors. I haven’t fully fleshed out exactly what that might look like, but it would be useful to have a GitHub issue to track against. There are also probably some open issues that would fold into it.

elitemn commented 7 years ago

Agreed. I'll, open one.

timGerken commented 7 years ago

can you update this PR with the fix cited above?