search

microsoft / Git-Credential-Manager-for-Windows

Secure Git credential storage for Windows with support for Visual Studio Team Services, GitHub, and Bitbucket multi-factor authentication.
Other
2.87k stars 591 forks source link

GCM ignores NO_PROXY environment variable #876

Open u1735067 opened 4 years ago

u1735067 commented 4 years ago

Hello,

I see in https://github.com/microsoft/Git-Credential-Manager-for-Windows/blob/master/Docs/Environment.md honor http_proxy and https_proxy (both upper and lower case it seems), but it completely ignores no_proxy while git honor it.

So git is properly handling requests, but GCM can leaks informations through the proxy while it shouldn't.

Could GCM handle this environment variable the same way gitdoes, which is https://curl.haxx.se/docs/manual.html (§Environment Variables, as per https://github.com/git/git/search?q=no_proxy&unscoped_q=no_proxy)?

Best,