microsoft / GitHub-Copilot-for-Azure

GitHub Copilot for Azure
Other
14 stars 1 forks source link

Thumbs up/down do not always appear, sometimes a new message is necessary #20

Closed bwateratmsft closed 1 week ago

bwateratmsft commented 1 week ago

In some cases (in particular, when we're deferring response parts), the thumbs up/down buttons do not appear. You have to send another message and then they appear. This is going to prevent us from getting feedback from end users.

I suspect this is an upstream issue.

/cc @isidorn

isidorn commented 1 week ago

@roblourens I can reproduce this.

  1. Install https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azure-github-copilot
  2. Open chat view -> "How do I deploy this app to azure?"
  3. Response does not have Thumbs Up / Thumbs Down

Might it be that we are awaiting on some part of the response? I assume we only render the Thumbs up / Thumbs down once we know the response has completed.

@bwateratmsft can you reproduce with a starter sample if you defer the response parts? Or can you provide more details on how you are deferring it in Azure?

bwateratmsft commented 1 week ago

I'll try to reproduce with the starter sample. I don't think there's anything particularly special about our "deferred response parts", they just get sent after the LLM is done.

bwateratmsft commented 1 week ago

@isidorn @roblourens I'm able to reproduce with the chat sample by simply sending a large Markdown chunk at the end of the response, in this case under @cat /randomTeach. Here's my fork/branch: https://github.com/bwateratmsft/vscode-extension-samples/tree/bmw/catchat

The changes are just this: https://github.com/bwateratmsft/vscode-extension-samples/commit/981b71b1f4c53f8fb719f5d0198a8d888e84c5ba

roblourens commented 1 week ago

Thanks- opened https://github.com/microsoft/vscode/issues/234034

isidorn commented 1 week ago

Thanks Rob and Brandon. I just tried it out with latest VS Code Insiders and it looks fixed for me with your latest changes Rob. Brandon if you still see the issue do let us know.

bwateratmsft commented 1 week ago

Verified it's working now, thanks for the quick fix @roblourens!

charris-msft commented 1 week ago

Double-verified! Big thanks @bwateratmsft & @roblourens!