search

microsoft / GlobalMLBuildingFootprints

Worldwide building footprints derived from satellite imagery
Other
1.33k stars 198 forks source link

Preserve 'height' Attribute in Output GeoJSON #95

Closed wanhanlong1130 closed 4 months ago

wanhanlong1130 commented 4 months ago

This pull request addresses an issue where the original 'properties' values were being overwritten by a new 'id' value, resulting in the omission of 'height' and 'confidence' information when downloading data using the example notebook script. To resolve this, I have implemented an alternative approach utilizing a GeoDataFrame. This modification ensures that the 'height' attribute is preserved and included in the output GeoJSON file, enhancing the data's completeness and utility. This change is crucial for users who rely on the 'height' attribute for their analyses or applications.

wanhanlong1130 commented 4 months ago

@microsoft-github-policy-service agree

andwoi commented 4 months ago

@wanhanlong1130 thanks for the PR! This looks good. Can you clear the notebook outputs?

wanhanlong1130 commented 4 months ago

@andwoi Sorry for the oversight; have now cleared the outputs.

andwoi commented 4 months ago

no worries. Thanks!