[Bug Report] There is a little bug in Network lib

microsoft / GraphEngine

Microsoft Graph Engine

http://www.graphengine.io/

MIT License

2.19k stars 328 forks source link

[Bug Report] There is a little bug in Network lib #335

Closed qingzhu521 closed 2 years ago

qingzhu521 commented 2 years ago

In our experiment, we found when we load a large cell to client. The client will break. And the server will continue without loading the large cell. As we debug, we found there is a bug in src/Trinity.C/src/Network/Network.cpp:220. There is no way for Network::send_async(p_sock) to return E_SUCCESS, but the left hand of == is E_SUCCESS. It should be E_RETRY.

TaviTruman commented 2 years ago

@qingzhu521 Thanks for reporting this! I will include a fix and testing in this week's build.

qingzhu521 commented 2 years ago

@TaviTruman which branch is up to data branch?

TaviTruman commented 2 years ago

@qingzhu521 https://github.com/InKnowWorks/GraphEngine