search

microsoft / HoloJS

Provides a framework for creating holographic apps using JavaScript and WebGL.
MIT License
1.19k stars 114 forks source link

In readme, s/Chakra/ChakraCore/g, plus a convenient link #9

Closed bterlson closed 7 years ago

msftclas commented 7 years ago

Hi @bterlson, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Brian Terlson). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

lwansbrough commented 7 years ago

It's not actually ChakraCore though, according to the pre compiled header: https://github.com/Microsoft/HoloJS/blob/master/HoloJS/HoloJsHost/pch.h#L9

Though based on the code thats being used from Chakra, it looks possible to make the switch to ChakraCore (I haven't looked through everything yet, but I didn't see any Windows namespace projections happening, for instance.) Would possibly reduce the binary size by a few MB.

Almost-Done commented 7 years ago

JsStartDebugging is the only missing function from ChakraCore. Without it, debugging a script in Visual Studio is not possible. Chakra is present on all Windows editions, including HoloLens, and this project is dynamically linked against it.

lwansbrough commented 7 years ago

@Almost-Done Maybe use some preprocessor directives to disable debugging + target ChakraCore for production?

bterlson commented 7 years ago

See I thought I remembered that this was targeting Chakra, but then the readme linked to ChakraCore's GitHub repo. It's a bit confusing, but without a better place to link to I don't know that anything needs to change.

liminzhu commented 7 years ago

@bterlson maybe link to Chakra JSRT doc?