microsoft / HoloLens2ForCV

Sample code and documentation for using the Microsoft HoloLens 2 for Computer Vision research.
MIT License
480 stars 145 forks source link

Fixbug save_pclouds.py #29

Closed IkbeomJeon closed 3 years ago

IkbeomJeon commented 3 years ago

I have found bugs since I try to run tsdf script. The bugs is made by save_pclouds.py script. Please confirm my reports. (It's only tested in Windows 10)

1.Fix wrong type : WindowPath -> str(path) on np.loadtxt() 2.Fix wrong generation code : rgb, depth filepath in [pinhole_projection/depth.txt, rgb.txt]

  1. 'is not' keyword seems to make warnnig in python 3.8
  2. default state of parameter 'disable_project_pinhole' in 'save_pclouds()' changed to true.
  3. remove 'skip code' of generating .ply if it already exist. So files in 'pinhole_projection' will be overwrited if it is already exists. Nevertheless, The reason why it need to be overwrited is that original code have possibility to create bug that it also does not create right .txt files(rgb,depth,odometry,trajectory...) if .ply was already generated by other script.
ghost commented 3 years ago

CLA assistant check
All CLA requirements met.