microsoft / HoloLensForCV

Sample code and documentation for using the Microsoft HoloLens for Computer Vision research
MIT License
472 stars 156 forks source link

Add unity plugin for detecting aruco markers with rgb camera intrinsic parameters #78

Closed chrisfromwork closed 5 years ago

chrisfromwork commented 5 years ago

This review contains the following new functionality: 1) A dll for capturing rgb frames to identify ArUco markers with opencv and accurate camera intrinsic parameters (UnityArUcoMarkerDetectorPlugin.dll) 2) A script for using the dll in unity (UnityArUcoMarkerDetectorPluginAPI.cs)

A change was needed within the existing HoloLensForCV dll for this to work: 1) The frame spatial coordinate system is now cached in the frame helper class. This spatial coordinate system is needed in order to obtain transforms between the winrt frame's spatial coordinate system and the unity scene's spatial coordinate system.

chrisfromwork commented 5 years ago

@polszta Is it possible to get a review for this change?