Fix sleep between retries of startRecordingScreen

DavidAsulin1 commented 12 months ago

Description

A minor fix for the sleep time between startRecordingScreen. The retryAndSleepWhenFalse takes sleepSeconds param and it's set to 1000 second (probably a mistake). I changed the value to 10 second (align with the other usages of this method).

Pull Request Checklist

[ ] Tests for the changes have been added (for bug fixes / features)
[x] Code compiles correctly with all tests are passed.
[x] I've read the contributing guide and followed the recommended practices.
[ ] Wikis or README have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

[ ] Yes
[x] No

How you tested it

I encounter an issue running test on a mac machine. If appium failed to start the recording the retryAndSleepWhenFalse enter a very long sleep of 1000 seconds which block the test. Changing the value to 10 second (align with the other usages of this method) did fix the issue.

Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[ ] Technical design
[ ] Build related changes
[ ] Refactoring (no functional changes, no api changes)
[ ] Code style update (formatting, renaming) or Documentation content changes
[ ] Other (please describe):