search

microsoft / IIS.ServiceMonitor

An entrypoint process for running IIS in Windows containers
MIT License
126 stars 42 forks source link

Fix typo in shutdown message #14

Closed diogosalazar closed 6 years ago

diogosalazar commented 6 years ago

Small typo there. I also think the way the message reads is a bit weird right now.

jimmyca15 commented 6 years ago

@diogosalazar

You're right the wording is weird here. I think rather than just fixing the typo, we should revisit the message.

jimmyca15 commented 6 years ago

@mcy94w

The sentence should be something along the lines of "Terminating the process because the CTRL signal was received." or "CTRL signal received. The process will now terminate."

jamestelfer commented 6 years ago

This message with the typo is shipping in the ASP.NET container. Can I help somehow get this minor change modified further and through review? It seems rude to just raise a different pull request.

shirhatti commented 6 years ago

@diogosalazar Do you mind updating your PR with the phrasing Jimmy suggested? If not, do you mind I push directly to your branch with the updated text

diogosalazar commented 6 years ago

@shirhatti I've changed the message as per your guys' suggestion. Looks good to me now.

shirhatti commented 6 years ago

Thanks @diogosalazar!