search

microsoft / IIS.ServiceMonitor

An entrypoint process for running IIS in Windows containers
MIT License
126 stars 42 forks source link

Environment variable names are converted to uppercase in the container #32

Closed vjgn closed 5 years ago

vjgn commented 6 years ago

ServiceMonitor converts the environment variable names to upper case when adding to the app pool process. Below line in IISConfigUtil.cpp seems to do a in place conversion of the environment name to upper case. FilterEnv(filter, CharUpper(pstrNameCheck), pstrValue) This is causing environment variable replacement using ConfigBuilders to fail unless we change all AppSetting keys to be upper case which is not ideal.

mcy94w commented 6 years ago

I will make a fix in this week.

vjgn commented 6 years ago

Any ETA on the fix. Thank you.

mcy94w commented 6 years ago

I have commented on your PR. https://github.com/Microsoft/IIS.ServiceMonitor/pull/33

shirhatti commented 5 years ago

Fixed in #33

gislikonrad commented 5 years ago

Any news on a release, or do I need to compile this myself?

I'm using the mcr.microsoft.com/dotnet/framework/aspnet:4.7.2-windowsservercore-ltsc2016 container as a base image. According to the Dockerfile in the repo for that image, they are using v 2.0.1.6 of service monitor which is signed on october 5 2018. Is this fix supposed to be in that binary, because I'm still getting uppercase environment variables in the applicationhost.config.

shirhatti commented 5 years ago

@bariscaglar looks like this slipped through the cracks. Do you have someone who can take a look at releasing this?

shirhatti commented 5 years ago

Actually looks like I misspoke. 2.0.1.6 has this change in it already

shirhatti commented 5 years ago

Jumped the gun on that. Looked back on the build history. 2.0.1.6 was built from 5f6d9673131817e52b481f8005cc782c90290860