Prevent environment variables names from being converted to upper case

microsoft / IIS.ServiceMonitor

An entrypoint process for running IIS in Windows containers

MIT License

126 stars 42 forks source link

Prevent environment variables names from being converted to upper case #33

Closed vjgn closed 5 years ago

vjgn commented 6 years ago

This change will prevent automatic conversion of environment variables to upper case when adding to the app pool. Automatic case conversion is not ideal as it breaks ConfigBuilders and other code that searches for environment variables with exact case.

mcy94w commented 6 years ago

Please fix the indentation and use space instead of tabs.

vjgn commented 5 years ago

I am using spaces for indentation and everything is aligning up correctly for me. Let me see if git for windows is changing anything during check-in.

vjgn commented 5 years ago

@mcy94w I am not seeing any alignment issues. I have opened the file in binary mode and see that it has no tab characters. May I know what indentation issue you are seeing. Thank you.

shirhatti commented 5 years ago

@mcy94w reminder to take a look