Timezone information is displayed wrong in Raystation

microsoft / InnerEye-DICOM-RT

DICOM-RT to mask python package used by https://github.com/microsoft/InnerEye-deeplearning

https://aka.ms/innereye

MIT License

8 stars 6 forks source link

Timezone information is displayed wrong in Raystation #13

Closed ant0nsc closed 2 years ago

ant0nsc commented 2 years ago

When viewing segmentation results in RayStation, the displayed time is about 1h off. This could mean either that the time encoded by IE-DicomRT is not correctly localized, or that RayStation is not displaying timezone info correctly. We should go through the code here and ensure that IE-DicomRT is correctly storing its processing time in UTC.

ant0nsc commented 2 years ago

https://github.com/microsoft/InnerEye-DICOM-RT/blob/11bdeaeaa740b4954764f3f1f6dc443930981917/RTConvert/Microsoft.RTConvert.MedIO/RT/DicomRTSeries.cs#L60 writes a plain string from UtcNow. However no information is attached about the timezone offset for that.

Possible solution:

Use the TimezoneOffset tag as described here
Encode the timezone offset as described in table 6.2-1 of the standard