Correct misspelled 'singletone' to 'singleton'

microsoft / InventorySample

Sample UWP application for LOB scenarios

MIT License

591 stars 199 forks source link

Correct misspelled 'singletone' to 'singleton' #40

Closed yannduran closed 6 years ago

yannduran commented 6 years ago

Each place where singleton was referenced, it was misspelled as singletone.

After checking the

AddSingleton<TService, TImplementation>

method in the the

Microsoft.Extensions.DependencyInjection.ServiceLocator

class hadn't also been misspelled, I located and fixed the mistakes.

Alvaromah commented 6 years ago

@yannduran Thanks for your help! Why did you close the pull request?

yannduran commented 6 years ago

@Alvaromah I wasn't aware that I had. I'm using Visual Studio 2017 to manage pull requests. I guess that something that I did closed the PR, because I didn't close it on purpose.

I noticed above it says that I deleted the feature branch (I've now restored it). This appears to have closed the PR. I didn't delete it on purpose.

I use Git Flow, so when I closed the feature, the feature branch got deleted, which then appears to have closed the PR. In future I'll make sure not to close the feature until the PR has been merged.

I have some more corrections to come in another PR.

Alvaromah commented 6 years ago

Merged. Thanks for your contribution!