search

microsoft / JARVIS

JARVIS, a system to connect LLMs with ML community. Paper: https://arxiv.org/pdf/2303.17580.pdf
MIT License
23.58k stars 1.96k forks source link

Function names in taskbench/generate_graph.py may be incorrect #231

Closed TakuyaHiraoka closed 7 months ago

TakuyaHiraoka commented 7 months ago

If my understanding is correct, the name of the function at line 4 should be "generate_graph_resource" as this function processes only type-specific parameters. https://github.com/microsoft/JARVIS/blob/92985b7aabfdd02c01939e5066448847f4dfe981/taskbench/generate_graph.py#L4-L20

Also, the name for the function at line 22 may be "generate_graph_temporal" as this function processes APIs with request parameters. https://github.com/microsoft/JARVIS/blob/92985b7aabfdd02c01939e5066448847f4dfe981/taskbench/generate_graph.py#L22-L43

tricktreat commented 7 months ago

Yes, thank you. We have already fixed it.