search

microsoft / LMOps

General technology for enabling AI capabilities w/ LLMs and MLLMs
https://aka.ms/GeneralAI
MIT License
3.69k stars 282 forks source link

Bug in Logit Processor? #272

Open SaeedNajafi opened 1 month ago

SaeedNajafi commented 1 month ago

Don't you have a bug in the logit processor? It seems you don't even use the processed scores in the wrapper.

https://github.com/microsoft/LMOps/blob/96e7d9d086cba6cd878c98ac810902eae1323d8b/minillm/transformers/src/transformers/generation/utils.py#L2942

t1101675 commented 1 month ago

Thanks for pointing it out! We have fixed this issue in this commit.