search

microsoft / LSKV

A Ledger-backed Secure Key-Value store (LSKV), built on the Confidential Consortium Framework (CCF)
https://microsoft.github.io/CCF
MIT License
34 stars 6 forks source link

Move benchmarks to run docker containers #141

Open jeffa5 opened 1 year ago

jeffa5 commented 1 year ago

Is your feature request related to a problem? Please describe.

Currently the benchmarks run the binaries themselves, this is ok for developers as they will have all of the dependencies already available and should be able to build the artifacts. However, for increased reproducibility I think it would be better to have the benchmarks run in containers. This standardises the version and we can publish tagged images from GH releases.

Describe the solution you'd like

The benchmarks run the nodes in docker containers rather than using the local enclave objects.

Describe alternatives you've considered

Continuing running as is, see above.

jeffa5 commented 1 year ago

Completed for lskv nodes, not yet for etcd.