search

microsoft / LSKV

A Ledger-backed Secure Key-Value store (LSKV), built on the Confidential Consortium Framework (CCF)
https://microsoft.github.io/CCF
MIT License
35 stars 6 forks source link

Fix notice check #164

Closed jeffa5 closed 1 year ago

jeffa5 commented 1 year ago

This reworks the notice_check.py to use git ls-files and exclude some things from that. It also reworks the logic for checking for the license lines to be a bit more robust in the face of formatting.

github-actions[bot] commented 1 year ago

Plots from benchmarking at c73ff2f2a8e02066b6c8c1c057f0f2e05ca74b47

Available from here

etcd/achieved_throughput_bar-vars-None-nodes.jpg
etcd/ecdf-latency_ms-None-nodes-vars.jpg
etcd/scatter-start_ms-latency_ms-None-nodes-vars.jpg
etcd/target_throughput_latency_line-rate-None-nodes-vars.jpg
etcd/throughput_bar-rate-None-nodes-vars.jpg
k6/achieved_throughput_bar-vars-None-nodes.jpg
k6/ecdf-latency_ms-None-nodes-vars.jpg
k6/scatter-start_ms-latency_ms-None-nodes-vars.jpg
k6/target_throughput_latency_line-rate-None-nodes-vars.jpg
k6/throughput_bar-rate-None-nodes-vars.jpg
perf/achieved_throughput_bar-vars-http_version-nodes.jpg
perf/ecdf-latency_ms-http_version-nodes-vars.jpg
perf/scatter-start_ms-latency_ms-http_version-nodes-vars.jpg
ycsb/achieved_throughput_bar-vars-None-None.jpg
ycsb/ecdf-latency_ms-nodes-operation-vars.jpg
ycsb/scatter-start_ms-latency_ms-nodes-operation-vars.jpg
ycsb/target_throughput_latency_line-rate-None-nodes-vars.jpg
ycsb/throughput_bar-rate-nodes-operation-vars.jpg
jeffa5 commented 1 year ago

Nice, are any of these changes worth upstreaming to CCF?

I wouldn't think they're urgent but maybe eventually.