microsoft / LSKV

A Ledger-backed Secure Key-Value store (LSKV), built on the Confidential Consortium Framework (CCF)
https://microsoft.github.io/CCF
MIT License
34 stars 6 forks source link

Require user certs on the endpoints #169

Closed jeffa5 closed 1 year ago

jeffa5 commented 1 year ago

Whilst not fully authenticating users with permissions this does mean they have to connect with a client cert.

Fixes #168

github-actions[bot] commented 1 year ago

Plots from benchmarking at ac6d125eace8dc66686082bc2e2fef2c5f0c00f0

Available from here

etcd/achieved_throughput_bar-vars-None-nodes.jpg
etcd/ecdf-latency_ms-None-nodes-vars.jpg
etcd/scatter-start_ms-latency_ms-None-nodes-vars.jpg
etcd/target_throughput_latency_line-rate-None-nodes-vars.jpg
etcd/throughput_bar-rate-None-nodes-vars.jpg
k6/achieved_throughput_bar-vars-None-nodes.jpg
k6/ecdf-latency_ms-None-nodes-vars.jpg
k6/scatter-start_ms-latency_ms-None-nodes-vars.jpg
k6/target_throughput_latency_line-rate-None-nodes-vars.jpg
k6/throughput_bar-rate-None-nodes-vars.jpg
perf/achieved_throughput_bar-vars-http_version-nodes.jpg
perf/ecdf-latency_ms-http_version-nodes-vars.jpg
perf/scatter-start_ms-latency_ms-http_version-nodes-vars.jpg
ycsb/achieved_throughput_bar-vars-None-None.jpg
ycsb/ecdf-latency_ms-nodes-operation-vars.jpg
ycsb/scatter-start_ms-latency_ms-nodes-operation-vars.jpg
ycsb/target_throughput_latency_line-rate-None-nodes-vars.jpg
ycsb/throughput_bar-rate-nodes-operation-vars.jpg
jeffa5 commented 1 year ago

Not the default for etcd, they default to open, but this should aid in auditability a bit as only users we've shared the cert with can connect. The benchmarking logic for etcd is also set to use client certs so this increases the parity in those.