search

microsoft / LightLDA

Scalable, fast, and lightweight system for large-scale topic modeling
http://www.dmtk.io
MIT License
842 stars 234 forks source link

reserved identifier violation #1

Closed elfring closed 8 years ago

elfring commented 8 years ago

I would like to point out that identifiers like "_LIGHTLDA_DATA_STREAM_H_" and "_LIGHTLDA_TRAINER_H_" do eventually not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

feiga commented 8 years ago

Very useful comments. Thanks very much! I fixed this.

elfring commented 8 years ago

Thanks for your improvement of affected include guards.