microsoft / LightLDA

Scalable, fast, and lightweight system for large-scale topic modeling
http://www.dmtk.io
MIT License
842 stars 234 forks source link

Improve exception safety with smart pointers #3

Closed elfring closed 8 years ago

elfring commented 8 years ago

Would you like to wrap any pointer data members with the template class "std::unique_ptr"?

Update candidate: AliasTable

feiga commented 8 years ago

Thanks. The memory here is managed well. May consider change to smart pointer later.

elfring commented 8 years ago

Should this issue be kept open until the affected implementation details will be fixed?