search

microsoft / Linux-CommA

The Linux Commit Analyzer tracks patches from upstream and downstream kernels.
MIT License
8 stars 8 forks source link

Is it necessary to skip the root commit in process_commits() #54

Closed avylove closed 1 year ago

avylove commented 1 year ago

Original comment

        # First ever commit, we don't need to store this as it'll be present in any distro
        # TODO revisit, maybe check against set hash of first commit?
        # Get code some other way? Unsure if first commit matters or not.

This skips commits if they don't have parent, i.e. root commit. There's no checking to make sure the root commits match and other mechanisms should filter out the root commit if it even comes up, so this probably isn't necessary. Technically, in the current state, it would be wrong if compared against an empty repo.

avylove commented 1 year ago

Determined there should be no downside in skipping this. Completed in #67