microsoft / MCW-App-modernization

MCW App modernization
MIT License
175 stars 264 forks source link

GitHub Action getting failed in Exercise-4 Task-3 #111

Closed karthikkc24 closed 2 years ago

karthikkc24 commented 2 years ago

In Exercise-4 Task-3: Setting up CI/CD with GitHub Actions Step-14, github action to update stagingdeploy.yml is getting failed with the following error in the screenshot.

image

Tried by Authorizing the App service - Deployment Center by following https://docs.microsoft.com/en-us/azure/app-service/deploy-github-actions?tabs=applevel. But still it is failing.

And the same thing happening with the Task 4: Pushing code changes to staging and production, at step-8 after pushing the changes from visual studio code and the New Home Page Title github action is also getting failed with the same error.

In Exercise-5 Task-3 Step-9, unable to process the order request.

image

eldridgeb commented 2 years ago

We noticed this yesterday too. I suspect this may be related to this recent release to the GitHub Actions image which bumped up Node and Npm versions: https://github.com/actions/virtual-environments/releases/tag/ubuntu20%2F20211129.1

Though I'm not really sure what to do about that.. :/

akn9050 commented 2 years ago

hi @timahenning @DawnmarieDesJardins I noticed in exercise 4 task 3 step 11, there is no file with following path C:\MCW\MCW-App-modernization-main\Hands-on lab\lab-files\workflow\stagingdeploy.yml, and

we already have the file in workflow folder locally after pulling the changes from remote at this step which has different content as compared with screenshot instructions.

Can we please investigate and priorities this issue.

fatihdurgut commented 2 years ago

My HOL also failed in the same place.

PartsUnlimitedWebsite.csporj has the following script. GitHub could not run the npm install part.

  <Target Name="PrecompileScript" BeforeTargets="BeforeBuild">
    <Exec Command="npm install --python=python2.7" />
    <Exec Command="npm config set python python2.7" />
    <Exec Command="npm install -g grunt-cli --force" />
    <Exec Command="grunt" />
  </Target>
eldridgeb commented 2 years ago

As a workaround, you can switch to the Windows GitHub hosted runner. The build completes without error and looks okay to me.

So change: https://github.com/microsoft/MCW-App-modernization/blob/main/Hands-on%20lab/lab-files/workflow/stagingdeploy.yml#L15 to windows-latest

fatihdurgut commented 2 years ago

windows-latest

This worked. Thanks.

timahenning commented 2 years ago

C:\MCW\MCW-App-modernization-main\Hands-on lab\lab-files\workflow

Hi @

hi @timahenning @DawnmarieDesJardins I noticed in exercise 4 task 3 step 11, there is no file with following path C:\MCW\MCW-App-modernization-main\Hands-on lab\lab-files\workflow\stagingdeploy.yml, and

we already have the file in workflow folder locally after pulling the changes from remote at this step which has different content as compared with screenshot instructions.

Can we please investigate and priorities this issue.

I have created a new issue for this separate thread.

timahenning commented 2 years ago

Hi @eldridgeb and @fatihdurgut,

Thank you for your initial investigation. I guess the ubuntu-latest image has been updated. I have tested with windows-2019.

Tim

DawnmarieDesJardins commented 2 years ago

Closing as resolved with merge or PR #114