search

microsoft / MHA

Message Header Analyzer Add-in For Outlook
MIT License
291 stars 53 forks source link

._getOpacity exceptions #111

Closed stephenegriffin closed 5 years ago

stephenegriffin commented 5 years ago
  problemId window.getComputedStyle(...) is null at i</e.prototype._getOpacity
  type window.getComputedStyle(...) is null
  assembly https://static2.sharepointonline.com/files/fabric/office-ui-fabric-js/1.5.0/js/fabric.min.js
  method i</e.prototype._getOpacity
  client_Browser Firefox 60.0

getComputedStyle can return null on firefox < v62: https://developer.mozilla.org/en-US/docs/Web/API/Window/getComputedStyle

This breaks fabric: https://static2.sharepointonline.com/files/fabric/office-ui-fabric-js/1.5.0/js/fabric.js Spinner.prototype._getOpacity = function (element) { return parseFloat(window.getComputedStyle(element).getPropertyValue("opacity")); };

stephenegriffin commented 5 years ago

I've tried firefox v60 and 56 but cannot repro. If anyone has repro details, lemme know

stephenegriffin commented 5 years ago

https://bugzilla.mozilla.org/show_bug.cgi?id=548397

stephenegriffin commented 5 years ago

still getting reports at Firefox 52.0

stephenegriffin commented 5 years ago

May have fixed this with 91ab85e