search

microsoft / MIDI

Windows MIDI Services
MIT License
297 stars 24 forks source link

[BUG] Return manufacturer name from ACX driver #288

Open Psychlist1972 opened 5 months ago

Psychlist1972 commented 5 months ago

Describe the bug

Current driver impl doesn't yet return device manufacturer name from the iManufacturer string in the device descriptors.

AmeNote-Michael commented 5 months ago

Added with KSPROPERTY of:

KSPROPERTY_MIDI2_DEVICE_MANUFACTURER

Psychlist1972 commented 5 months ago

Added with KSPROPERTY of:

KSPROPERTY_MIDI2_DEVICE_MANUFACTURER

@AmeNote-Michael

As with VID/PID, these were there already

https://github.com/microsoft/MIDI/blob/main/src/api/Inc/MidiKSDef.h

AmeNote-Michael commented 5 months ago

Feature missed during a merge. Readded and in pull request #301

Psychlist1972 commented 3 months ago

Reopening until we ship to customers

Psychlist1972 commented 5 days ago

This is fixed in the August 2024 driver release. However, it will require DP7 for folks to see the name in the SDK or midi console.