Issues: 300, 288, 286, 269, 245, 198, 181

AmeNote-Michael commented 1 week ago

This pull request covers multiple issues related to driver as listed below:

Issue #300: MidiSrv gets stuck by sending MT3.

issue specific in sending empty SYSEX message "F0 F7", which was not being handled by driver. Driver now handles empty SYSEX.

Issue #288: Return manufacturer name from ACX driver

Issue #286: USB MIDI 2 Driver returns incorrect size for iSerialNumber property

Issue #269: MIDI.exe returns different GTB than returned via USB

driver returned all GTBs defined - now returns only GTBs defined and Indexed by Endpoints.

Issue #245: MIDI Service gets stuck.

earlier driver version tried to filter out undefined messages but got into an endless loop. Driver now will pass message on for upper layers to handle.

Issue #198: Roland-reported WDF_VIOLATION crash with MIDI 2.0 driver and Roland UM-One

resolved in fixing power management issue. BE SURE you have UM-One that is compatible with Windows 11 and that you are in TAB mode for class compliance on the UM-One. There are some UM-Ones that state they are not compatible with Windows 11.

Issue #181: Green screen appears when assigned USB MIDI 2.0 driver to a UMP device

resolved in fixing power management issue.

Issue #165: Green screen appears when assigned USB MIDI 2.0 driver to a UMP device

Issue was due to architecture of USB Out packets from UMP. UMP presented from service layer as individual UMP packets (max 4 bytes). Driver now will try to consolidate into single max size USB packets if it knows more data available from Service.

Arm64 Driver Version ready for extensive testing. This version of driver is ready to be compiled and tested on Arm64 based Windows environments.

Psychlist1972 commented 3 days ago

@AmeNote-Michael do you want me to reject this PR given what you are currently working on, or do you intend to issue another PR afterwards with just the delta?

AmeNote-Michael commented 3 days ago

@AmeNote-Michael do you want me to reject this PR given what you are currently working on, or do you intend to issue another PR afterwards with just the delta?

Lets complete the PR. There was a lot of changes and I would prefer to lock down here before I really dig into the changes for SpinLocks over Mutex's.

Wait for Attestation signing for next PR.

Psychlist1972 commented 3 days ago

Please resolve the conflicts first. Also, attestation signing requires a fair bit of work from the Microsoft team, so prefer to hold on that until you have a complete version of the driver with the mutex changes.

AmeNote-Michael commented 2 days ago

@Psychlist1972 I have resolved conflict - missed removing one element of vcpkg addition.

microsoft / MIDI

Issues: 300, 288, 286, 269, 245, 198, 181 #353