search

microsoft / MIEngine

The Visual Studio MI Debug Engine ("MIEngine") provides an open-source Visual Studio Debugger extension that works with MI-enabled debuggers such as gdb and lldb.
MIT License
818 stars 219 forks source link

Refactor Engine Logging and Add Natvis Diagnostic Logging #1322

Closed WardenGnaw closed 2 years ago

WardenGnaw commented 2 years ago

This PR refactors how logging works for the MIEngine repo and adds a second logger for Natvis.

gregg-miskelly commented 2 years ago 
            res.WriteLine("Initialized log at: " + s_initTime.ToString(CultureInfo.InvariantCulture));

Check for natvis verbosity?

Refers to: src/MICore/Logger.cs:67 in 845c0a2. [](commit_id = 845c0a2086c2ab3c6a301cfac1243a8945d0a952, deletion_comment = False)

gregg-miskelly commented 2 years ago 
            res.WriteLine("Initialized log at: " + s_initTime.ToString(CultureInfo.InvariantCulture));

Actually, I guess that makes more sense to do in DebugEngineHost.

In reply to: 1176738598

Refers to: src/MICore/Logger.cs:67 in 845c0a2. [](commit_id = 845c0a2086c2ab3c6a301cfac1243a8945d0a952, deletion_comment = False)

WardenGnaw commented 2 years ago

Status: Still working on this PR, just getting things rebased and some issues addressed.

WardenGnaw commented 2 years ago

OSX test is flaky.